-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support env files #1022
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost done. Update plz 'man' and docs
too.
Man updated. I'll update docs in the morning |
Docs updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in most. Thanks!
https://github.com/google/zx/actions/runs/12478218485
|
Yeap, I fixed. |
Fix prettier |
44f81ad
to
db62520
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
Why a custom implementation and not |
I figured that would be enough weight for simple logic. |
@easymikey It is simple today, tomorrow people will request variable expansion and what's your plan? Copy |
I believe that if people demand it, then it can be done. Premature optimization is not needed here. But it's better for you to communicate with the mentainers. |
Strictly speaking, passing custom env file is not required, as you can simple use
|
Or this
|
Fixes #974